On Wed, 12 Feb 2025, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote:
> On Wed, Feb 12, 2025 at 06:36:29PM +0200, Jani Nikula wrote:
>> Convert a bunch of files and functions to struct intel display.
>>
>> The approach is to mostly convert a file, then see what the stragglers
>> are, convert those too, and repeat.
>>
>> The PCH checks are starting to become a big straggler for further
>> conversions.
>
> Aye. I wonder if we should in fact change all the HAS_PCH_FOO()
> stuff to some kind of "south display type" thing. The current
> situation is a bit of a mess due to:
> - DG1/2 declare some kind of fake PCH type
> - BXT/GLK don't declare one and yet we still use many
> PCH/south display registers
I'm also thinking most or all of the PCH checks outside of display
should be removed.
> Anyways, series is
> Reviewed-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
Thanks, pushed to din!
>
>>
>> BR,
>> Jani.
>>
>> Jani Nikula (14):
>> drm/i915/dp: convert g4x_dp.[ch] to struct intel display
>> drm/i915/hdmi: convert g4x_hdmi.[ch] to struct intel_display
>> drm/i915/ips: convert hsw_ips.c to struct intel_display
>> drm/i915/display: convert assert_transcoder*() to struct intel_display
>> drm/i915/display: convert assert_port_valid() to struct intel_display
>> drm/i915/hpd: drop dev_priv parameter from intel_hpd_pin_default()
>> drm/i915/display: convert
>> intel_set_{cpu,pch}_fifo_underrun_reporting() to intel_display
>> drm/i915/sdvo: convert intel_sdvo.[ch] to struct intel_display
>> drm/i915/display: convert intel_cpu_transcoder_mode_valid() to
>> intel_display
>> drm/i915/display: convert intel_mode_valid_max_plane_size() to
>> intel_display
>> drm/i915/dsi: convert platform checks to display->platform.<platform>
>> style
>> drm/i915/combo-phy: convert intel_combo_phy.[ch] to struct
>> intel_display
>> drm/i915/display: convert intel_fifo_underrun.[ch] to struct
>> intel_display
>> drm/i915/display: convert i915_pipestat_enable_mask() to struct
>> intel_display
>>
>> drivers/gpu/drm/i915/display/g4x_dp.c | 99 +++---
>> drivers/gpu/drm/i915/display/g4x_dp.h | 14 +-
>> drivers/gpu/drm/i915/display/g4x_hdmi.c | 154 +++++----
>> drivers/gpu/drm/i915/display/g4x_hdmi.h | 6 +-
>> drivers/gpu/drm/i915/display/hsw_ips.c | 26 +-
>> drivers/gpu/drm/i915/display/icl_dsi.c | 21 +-
>> .../gpu/drm/i915/display/intel_combo_phy.c | 180 ++++++-----
>> .../gpu/drm/i915/display/intel_combo_phy.h | 8 +-
>> drivers/gpu/drm/i915/display/intel_crt.c | 21 +-
>> drivers/gpu/drm/i915/display/intel_crtc.c | 2 +-
>> drivers/gpu/drm/i915/display/intel_ddi.c | 11 +-
>> drivers/gpu/drm/i915/display/intel_display.c | 155 ++++-----
>> drivers/gpu/drm/i915/display/intel_display.h | 10 +-
>> .../gpu/drm/i915/display/intel_display_irq.c | 37 +--
>> .../gpu/drm/i915/display/intel_display_irq.h | 5 +-
>> .../drm/i915/display/intel_display_power.c | 5 +-
>> .../i915/display/intel_display_power_well.c | 3 +-
>> drivers/gpu/drm/i915/display/intel_dp.c | 5 +-
>> drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 +-
>> drivers/gpu/drm/i915/display/intel_dpll.c | 30 +-
>> drivers/gpu/drm/i915/display/intel_dsi.c | 8 +-
>> drivers/gpu/drm/i915/display/intel_dvo.c | 8 +-
>> drivers/gpu/drm/i915/display/intel_fdi.c | 3 +-
>> .../drm/i915/display/intel_fifo_underrun.c | 181 ++++++-----
>> .../drm/i915/display/intel_fifo_underrun.h | 18 +-
>> drivers/gpu/drm/i915/display/intel_hdmi.c | 5 +-
>> drivers/gpu/drm/i915/display/intel_hotplug.c | 4 +-
>> drivers/gpu/drm/i915/display/intel_hotplug.h | 3 +-
>> drivers/gpu/drm/i915/display/intel_lvds.c | 6 +-
>> .../drm/i915/display/intel_modeset_setup.c | 6 +-
>> .../gpu/drm/i915/display/intel_pch_display.c | 4 +-
>> drivers/gpu/drm/i915/display/intel_pps.c | 11 +-
>> drivers/gpu/drm/i915/display/intel_sdvo.c | 293 +++++++++---------
>> drivers/gpu/drm/i915/display/intel_sdvo.h | 10 +-
>> drivers/gpu/drm/i915/display/intel_tv.c | 6 +-
>> drivers/gpu/drm/i915/display/vlv_dsi.c | 8 +-
>> 36 files changed, 671 insertions(+), 700 deletions(-)
>>
>> --
>> 2.39.5
--
Jani Nikula, Intel
