On Thu, 2025-01-16 at 19:47 +0200, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrj...@linux.intel.com> > > The if ladder in gen8_de_pipe_fault_mask() was missing one > else, add it. Doesn't actually matter since each if branch > just returns directly. But the code is less confusing when > you always do things the same way. > > Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> > --- > drivers/gpu/drm/i915/display/intel_display_irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Vinod Govindapillai <vinod.govindapil...@intel.com> > > diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c > b/drivers/gpu/drm/i915/display/intel_display_irq.c > index 069043f9d894..f06273d9bc8c 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_irq.c > +++ b/drivers/gpu/drm/i915/display/intel_display_irq.c > @@ -856,7 +856,7 @@ static u32 gen8_de_pipe_fault_mask(struct > drm_i915_private *dev_priv) > GEN9_PIPE_PLANE3_FAULT | > GEN9_PIPE_PLANE2_FAULT | > GEN9_PIPE_PLANE1_FAULT; > - if (DISPLAY_VER(display) >= 13 || HAS_D12_PLANE_MINIMIZATION(display)) > + else if (DISPLAY_VER(display) >= 13 || > HAS_D12_PLANE_MINIMIZATION(display)) > return GEN12_PIPEDMC_FAULT | > GEN9_PIPE_CURSOR_FAULT | > GEN11_PIPE_PLANE5_FAULT |
