> -----Original Message-----
> From: Nautiyal, Ankit K <ankit.k.nauti...@intel.com>
> Sent: Friday, January 31, 2025 9:44 AM
> To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org
> Cc: jani.nik...@linux.intel.com; Kandpal, Suraj <suraj.kand...@intel.com>;
> Vivi, Rodrigo <rodrigo.v...@intel.com>; david.laight.li...@gmail.com;
> naresh.kamb...@linaro.org
> Subject: [PATCH] drm/i915/dp: Return min bpc supported by source instead
> of 0
>
> Currently, intel_dp_dsc_max_src_input_bpc can return 0 for platforms not
> supporting DSC, which could theoretically cause issues in clamp() due to a
> low limit being greater than the high limit.
>
No need for the extra line above
Rest LGTM,
Reviewed-by: Suraj Kandpal <suraj.kand...@intel.com>
> Instead, return the minimum bpc supported by the source to prevent such
> issues.
>
> Reported-by: Linux Kernel Functional Testing <l...@linaro.org>
> Closes:
> https://lore.kernel.org/all/CA+G9fYtNfM399_=_ff81zeRJv=0+z7oFJfPGmJgTp6y
> rjmu...@mail.gmail.com/
> Fixes: 160672b86b0d ("drm/i915/dp: Use clamp for pipe_bpp limits with
> DSC")
> Cc: Suraj Kandpal <suraj.kand...@intel.com>
> Cc: Jani Nikula <jani.nik...@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.v...@intel.com>
> Signed-off-by: Ankit Nautiyal <ankit.k.nauti...@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index 80214a559013..d28abf081844 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -1791,7 +1791,7 @@ int intel_dp_dsc_max_src_input_bpc(struct
> intel_display *display)
> if (DISPLAY_VER(display) == 11)
> return 10;
>
> - return 0;
> + return intel_dp_dsc_min_src_input_bpc();
> }
>
> int intel_dp_dsc_compute_max_bpp(const struct intel_connector *connector,
> --
> 2.45.2
