Hi Mikolaj, > > + if (!ppgtt->vm.allocate_va_range) { > > + i915_vm_put(&ppgtt->vm); > > + return 0; > > + } > > I don't know if it feels more in line with kernel style, but consider > changing it to a label before second `i915_vm_put` at end of function > plus goto instead of creating new cleanup section.
I do not mind, we can place a label as well, as long as we avoid using that uninitialized struct. I will include your suggestion in v3. > Otherwise looks alright. > Reviewed-by: Mikolaj Wasiak <mikolaj.was...@intel.com> Thanks for reviewing! Krzysztof