Hi Ingyu, > diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c > b/drivers/gpu/drm/i915/gt/intel_ggtt.c > index d60a6ca0cae5..8d22d8f2243d 100644 > --- a/drivers/gpu/drm/i915/gt/intel_ggtt.c > +++ b/drivers/gpu/drm/i915/gt/intel_ggtt.c > @@ -311,7 +311,7 @@ static struct intel_context *gen8_ggtt_bind_get_ce(struct > i915_ggtt *ggtt, intel > * doing rpm_resume(). > */ > *wakeref = intel_gt_pm_get_if_awake(gt); > - if (!*wakeref) > + if (!*wakeref || *wakeref == INTEL_WAKEREF_DEF) INTEL_WAKEREF_DEF is a wrapper for an error pointer - how about IS_ERR_OR_NULL() macro? Without going a bit deeper into the code it is not apparent that INTEL_WAKEREF_DEF is indicating an error.
Nice catch nevertheless. Krzysztof > return NULL; > > intel_engine_pm_get(ce->engine); > -- > 2.34.1 >
