> -----Original Message----- > From: Intel-gfx <intel-gfx-boun...@lists.freedesktop.org> On Behalf Of Jouni > Högander > Sent: Thursday, January 9, 2025 1:02 PM > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Cc: Hogander, Jouni <jouni.hogan...@intel.com> > Subject: [PATCH v3 05/10] drm/i915/psr: Use SFF_CTL on invalidate/flush for > LunarLake onwards > > In LunarLake we have SFF_CTL register which contains SFF bit ored with > respective SFF bit in PSR2_MAN_TRK_CTL register. Use this register instead of > the bit in PSR2_MAN_TRK_CTL on frontbuffer tracking callbacks. This helps us > avoiding taking psr mutex when performing atomic commit. > > We don't need to set the CFF bit as selective update configuration in > PSR2_MAN_TRL_CTL is not overwritten anymore. I.e. we have valid > configuration in PSR2_MAN_TRK_CTL and in plane SEL_FETCH_* registers > when SFF bit gets cleared by the HW in case something triggers "frame > change" > event after SFF bit is cleared. > > Signed-off-by: Jouni Högander <jouni.hogan...@intel.com>
LGTM. Reviewed-by: Animesh Manna <animesh.ma...@intel.com> > --- > drivers/gpu/drm/i915/display/intel_psr.c | 22 +++++++++++++++------- > 1 file changed, 15 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c > b/drivers/gpu/drm/i915/display/intel_psr.c > index e6f96a8b4fb0..85ecedd3162d 100644 > --- a/drivers/gpu/drm/i915/display/intel_psr.c > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > @@ -2345,7 +2345,7 @@ void intel_psr2_program_trans_man_trk_ctl(const > struct intel_crtc_state *crtc_st > struct intel_dp *intel_dp = enc_to_intel_dp(encoder); > > lockdep_assert_held(&intel_dp->psr.lock); > - if (intel_dp->psr.psr2_sel_fetch_cff_enabled) > + if (DISPLAY_VER(display) < 20 && > +intel_dp->psr.psr2_sel_fetch_cff_enabled) > return; > break; > } > @@ -3118,12 +3118,16 @@ static void > intel_psr_configure_full_frame_update(struct intel_dp *intel_dp) > if (!intel_dp->psr.psr2_sel_fetch_enabled) > return; > > - intel_de_write(display, > - PSR2_MAN_TRK_CTL(display, cpu_transcoder), > - man_trk_ctl_enable_bit_get(display) | > - man_trk_ctl_partial_frame_bit_get(display) | > - man_trk_ctl_single_full_frame_bit_get(display) | > - man_trk_ctl_continuos_full_frame(display)); > + if (DISPLAY_VER(display) >= 20) > + intel_de_write(display, LNL_SFF_CTL(cpu_transcoder), > + LNL_SFF_CTL_SF_SINGLE_FULL_FRAME); > + else > + intel_de_write(display, > + PSR2_MAN_TRK_CTL(display, cpu_transcoder), > + man_trk_ctl_enable_bit_get(display) | > + man_trk_ctl_partial_frame_bit_get(display) | > + man_trk_ctl_single_full_frame_bit_get(display) | > + man_trk_ctl_continuos_full_frame(display)); > } > > static void _psr_invalidate_handle(struct intel_dp *intel_dp) @@ -3227,6 > +3231,10 @@ static void _psr_flush_handle(struct intel_dp *intel_dp) > * Still keep cff bit enabled as we don't have proper SU > * configuration in case update is sent for any reason after > * sff bit gets cleared by the HW on next vblank. > + * > + * NOTE: Setting cff bit is not needed for LunarLake onwards > as > + * we have own register for SFF bit and we are not > overwriting > + * existing SU configuration > */ > intel_psr_configure_full_frame_update(intel_dp); > } > -- > 2.43.0
