RE: [PATCH 1/5] drm/i915/dp: fix the Adaptive sync Operation mode for SDP

[Golani, Mitulkumar Ajitkumar]

> -----Original Message-----
> From: Nautiyal, Ankit K <ankit.k.nauti...@intel.com>
> Sent: Monday, June 3, 2024 6:33 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: jani.nik...@linux.intel.com; ville.syrj...@linux.intel.com; Golani,
> Mitulkumar Ajitkumar <mitulkumar.ajitkumar.gol...@intel.com>
> Subject: [PATCH 1/5] drm/i915/dp: fix the Adaptive sync Operation mode for
> SDP
> 
> Currently we support Adaptive sync operation mode with dynamic frame rate,
> but instead the operation mode with fixed rate is set.
> This was initially set correctly in the earlier version of changes but later 
> got
> changed, while defining a macro for the same.
> 
> Fixes: a5bd5991cb8a ("drm/i915/display: Compute AS SDP parameters")
> Cc: Mitul Golani <mitulkumar.ajitkumar.gol...@intel.com>
> Cc: Ankit Nautiyal <ankit.k.nauti...@intel.com>
> Cc: Jani Nikula <jani.nik...@linux.intel.com>
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nauti...@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index fd054e16850d..f33b2da1b084 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2634,10 +2634,10 @@ static void intel_dp_compute_as_sdp(struct
> intel_dp *intel_dp,
> 
>       crtc_state->infoframes.enable |=
> intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC);
> 
> -     /* Currently only DP_AS_SDP_AVT_FIXED_VTOTAL mode supported */
> +     /* Currently only DP_AS_SDP_AVT_DYNAMIC_VTOTAL mode supported
> */
>       as_sdp->sdp_type = DP_SDP_ADAPTIVE_SYNC;
>       as_sdp->length = 0x9;
> -     as_sdp->mode = DP_AS_SDP_AVT_FIXED_VTOTAL;
> +     as_sdp->mode = DP_AS_SDP_AVT_DYNAMIC_VTOTAL;

Changes LGTM.
Reviewed-by: Mitul Golani <mitulkumar.ajitkumar.gol...@intel.com>

>       as_sdp->vtotal = adjusted_mode->vtotal;
>       as_sdp->target_rr = 0;
>       as_sdp->duration_incr_ms = 0;
> --
> 2.40.1