> -----Original Message-----
> From: Sebastian Wick <[email protected]>
> Sent: Friday, April 5, 2024 10:46 PM
> To: Kandpal, Suraj <[email protected]>
> Cc: [email protected]; Borah, Chaitanya Kumar
> <[email protected]>; Shankar, Uma
> <[email protected]>; Nautiyal, Ankit K <[email protected]>;
> Murthy, Arun R <[email protected]>; Syrjala, Ville
> <[email protected]>; Kumar, Naveen1 <[email protected]>
> Subject: Re: [3/7] drm/i915/dp: Fix Register bit naming
>
> On Thu, Apr 04, 2024 at 08:59:27AM +0530, Suraj Kandpal wrote:
> > Change INTEL_EDP_HDR_TCON_SDP_COLORIMETRY enable to
> > INTEL_EDP_HDR_TCON_SDP_OVERRIDE_AUX as this bit is tells TCON to
> > ignore DPCD colorimetry values and take the one's sent through SDP.
>
> I actually like the original name because it tells the TCON to enable
> processing
> of SDP Colorimetry. The new name is okay as well.
But what this bit actually tells the TCON is to ignore the values in set
content_luminance, edp_hdr_getset_params dpcd register which were set through
aux. Hence to keep in line what this bit actually tell us renamed it
Regards,
Suraj Kandpal
>
> >
> > Signed-off-by: Suraj Kandpal <[email protected]>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> > b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> > index 94edf982eff8..3d9723714c96 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> > @@ -74,7 +74,7 @@
> > # define INTEL_EDP_HDR_TCON_BRIGHTNESS_AUX_ENABLE
> BIT(4)
> > # define INTEL_EDP_HDR_TCON_SRGB_TO_PANEL_GAMUT_ENABLE
> BIT(5)
> > /* Bit 6 is reserved */
> > -# define INTEL_EDP_HDR_TCON_SDP_COLORIMETRY_ENABLE
> BIT(7)
> > +# define INTEL_EDP_HDR_TCON_SDP_OVERRIDE_AUX
> BIT(7)
> >
> > #define INTEL_EDP_HDR_CONTENT_LUMINANCE
> > 0x346 /*
> Pre-TGL+ */
> > #define INTEL_EDP_HDR_PANEL_LUMINANCE_OVERRIDE
> 0x34A
