On Mon, 2023-10-16 at 14:16 +0300, Jouni Högander wrote: > Also make module parameter as non writable. > > Signed-off-by: Jouni Högander <jouni.hogan...@intel.com> > --- > drivers/gpu/drm/i915/display/intel_display.h | 2 +- > drivers/gpu/drm/i915/i915_params.c | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.h > b/drivers/gpu/drm/i915/display/intel_display.h > index 0e5dffe8f018..ba3548f9768d 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.h > +++ b/drivers/gpu/drm/i915/display/intel_display.h > @@ -552,7 +552,7 @@ bool assert_port_valid(struct drm_i915_private *i915, > enum port port); > struct drm_device *drm = &(__i915)->drm; \ > int __ret_warn_on = !!(condition); \ > if (unlikely(__ret_warn_on)) \ > - if (!drm_WARN(drm, i915_modparams.verbose_state_checks, > format)) \ > + if (!drm_WARN(drm, __i915->params.verbose_state_checks, > format)) \ > drm_err(drm, format); \ > unlikely(__ret_warn_on); \ > }) > diff --git a/drivers/gpu/drm/i915/i915_params.c > b/drivers/gpu/drm/i915/i915_params.c > index 3205c6b62670..4e8c088c69fd 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -93,8 +93,7 @@ i915_param_named(mmio_debug, int, 0400, > "Enable the MMIO debug code for the first N failures (default: off). " > "This may negatively affect performance."); > > -/* Special case writable file */ > -i915_param_named(verbose_state_checks, bool, 0600, > +i915_param_named(verbose_state_checks, bool, 0400, > "Enable verbose logs (ie. WARN_ON()) in case of unexpected hw state > conditions."); > > i915_param_named_unsafe(nuclear_pageflip, bool, 0400,
Reviewed-by: Luca Coelho <luciano.coe...@intel.com> -- Cheers, Luca.
