Hi Nirmoy, On Fri, Oct 13, 2023 at 03:44:39PM +0200, Nirmoy Das wrote: > gen8_ggtt_invalidate() is only needed for limited set of platforms > where GGTT is mapped as WC otherwise this can cause unwanted > side-effects on XE_HP platforms where GFX_FLSH_CNTL_GEN6 is not > valid. > > v2: Add a func to detect wc ggtt detection (Ville) > > Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement") > Cc: Rodrigo Vivi <rodrigo.v...@intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursu...@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> > Cc: Jani Nikula <jani.nik...@linux.intel.com> > Cc: Jonathan Cavitt <jonathan.cav...@intel.com> > Cc: John Harrison <john.c.harri...@intel.com> > Cc: Andi Shyti <andi.sh...@linux.intel.com> > Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> > Cc: <sta...@vger.kernel.org> # v6.2+ > Suggested-by: Matt Roper <matthew.d.ro...@intel.com> > Signed-off-by: Nirmoy Das <nirmoy....@intel.com> > Acked-by: Andi Shyti <andi.sh...@linux.intel.com>
I took some time to look at this and you can swap the a-b with an r-b: Reviewed-by: Andi Shyti <andi.sh...@linux.intel.com> Thanks, Andi