Xe is lacking the ability to re-use the ggtt_vma when updating cursor.
Instead of pinning from the new plane_state, move the ggtt_vma from
old_plane_state to new_plane_state.

Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_cursor.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_cursor.c 
b/drivers/gpu/drm/i915/display/intel_cursor.c
index 4962247911d41..6f34098ea314d 100644
--- a/drivers/gpu/drm/i915/display/intel_cursor.c
+++ b/drivers/gpu/drm/i915/display/intel_cursor.c
@@ -688,9 +688,8 @@ intel_legacy_cursor_update(struct drm_plane *_plane,
        if (ret)
                goto out_free;
 
-       ret = intel_plane_pin_fb(new_plane_state);
-       if (ret)
-               goto out_free;
+       /* magic trick! */
+       swap(new_plane_state->ggtt_vma, old_plane_state->ggtt_vma);
 
        intel_frontbuffer_flush(to_intel_frontbuffer(new_plane_state->hw.fb),
                                ORIGIN_CURSOR_UPDATE);
-- 
2.39.2

Reply via email to