On Fri, 12 May 2023, Rodrigo Vivi <rodrigo.v...@kernel.org> wrote: > On Fri, May 12, 2023 at 02:04:41PM +0300, Jani Nikula wrote: >> In general, we don't do assertions that a function gets called on the >> right platforms, and if we did, it should not be a state warn. >> >> Signed-off-by: Jani Nikula <jani.nik...@intel.com> > > Reviewed-by: Rodrigo Vivi <rodrigo.v...@intel.com>
Thanks for the review, pushed to din. BR, Jani. >> --- >> drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c >> b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c >> index ed372d227aa7..936b8de9e439 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c >> +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c >> @@ -464,8 +464,6 @@ static void ibx_assert_pch_refclk_enabled(struct >> drm_i915_private *dev_priv) >> u32 val; >> bool enabled; >> >> - I915_STATE_WARN_ON(!(HAS_PCH_IBX(dev_priv) || HAS_PCH_CPT(dev_priv))); >> - >> val = intel_de_read(dev_priv, PCH_DREF_CONTROL); >> enabled = !!(val & (DREF_SSC_SOURCE_MASK | DREF_NONSPREAD_SOURCE_MASK | >> DREF_SUPERSPREAD_SOURCE_MASK)); >> -- >> 2.39.2 >> -- Jani Nikula, Intel Open Source Graphics Center
