In the function intel_dp_max_bpp(), currently if bpc < 0 in case of error,
we return 0 instead of returning an err code of -EINVAL.
This throws off the logic in the calling function. Fix this by returning
-EINVAL in case bpc < 0 which would be an error.
Cc: Ville Syrjälä <ville.syrj...@linux.intel.com>
Cc: Ankit Nautiyal <ankit.k.nauti...@intel.com>
Cc: Sean Paul <s...@poorly.run>
Signed-off-by: Manasi Navare <navareman...@chromium.org>
---
drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
b/drivers/gpu/drm/i915/display/intel_dp.c
index f0bace9d98a1..f6546292e7c6 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1280,7 +1280,7 @@ static int intel_dp_max_bpp(struct intel_dp *intel_dp,
max_hdmi_bpc = intel_dp_hdmi_compute_bpc(intel_dp, crtc_state,
bpc,
respect_downstream_limits);
if (max_hdmi_bpc < 0)
- return 0;
+ return -EINVAL;
bpc = min(bpc, max_hdmi_bpc);
}
--
2.40.0.577.gac1e443424-goog
