On Mon, 27 Feb 2023 18:23:24 -0800, Umesh Nerlige Ramappa wrote:
>
> @@ -3378,12 +3376,13 @@ void i915_oa_init_reg_state(const struct 
> intel_context *ce,
>                           const struct intel_engine_cs *engine)
>  {
>       struct i915_perf_stream *stream;
> +     struct i915_perf_group *g = engine->oa_group;
>
> -     if (!engine_supports_oa(engine))
> +     if (!g)

Maybe leave the engine_supports_oa check here since the NULL oa_group check
is now implemented there.

Rest looks good to be overall so this is:

Reviewed-by: Ashutosh Dixit <ashutosh.di...@intel.com>

Reply via email to