On Dec-20-2013 7:35 PM, Daniel Vetter wrote: > On Fri, Dec 20, 2013 at 1:29 PM, Jani Nikula > <jani.nik...@linux.intel.com> wrote: >>> Signed-off-by: Pradeep Bhat <pradeep.b...@intel.com> >>> Signed-off-by: Vandana Kannan <vandana.kan...@intel.com> >>> Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> >>> Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk> >>> Reviewed-by: Jani Nikula <jani.nik...@linux.intel.com> >> >> I'm sorry, this is not true. Only I get to say when you can add my >> Reviewed-by. > > Yeah, you can't just add review-by comments. In the linux kernel this > has a very specific meaning and can't just get handed out for "has > looked at the patches". For details of what a reviewed-by tag means > please see the "Reviewer's statement of oversight" in > Documentation/SubmittingPatches. I've noticed that you've also done > this with Ville's r-b tag for the picture ratio patch, I'll send out a > note that this r-b isn't legit. > -Daniel > Thanks for your inputs. I will remove the r-b tag from all DRRS related patches, keeping the details of versions/review comments incorporated in the commit message. Also, I will follow the same and resend the patch on picture aspect ratio. - Vandana _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
- [Intel-gfx] [PATCH 0/5] Enabling DRRS in the kernel Vandana Kannan
- [Intel-gfx] [PATCH 2/5] drm/i915: Parse EDID probed mo... Vandana Kannan
- [Intel-gfx] [PATCH 5/5] drm/i915/bdw: Add support for ... Vandana Kannan
- [Intel-gfx] [PATCH 1/5] drm/i915: Adding VBT fields to... Vandana Kannan
- [Intel-gfx] [PATCH 3/5] drm/i915: Add support for DRRS... Vandana Kannan
- [Intel-gfx] [PATCH 4/5] drm/i915: Idleness detection ... Vandana Kannan
- [Intel-gfx] [PATCH 0/5] Enabling DRRS in the kernel Vandana Kannan
- [Intel-gfx] [PATCH 2/5] drm/i915: Parse EDID probe... Vandana Kannan
- Re: [Intel-gfx] [PATCH 2/5] drm/i915: Parse ED... Jani Nikula
- Re: [Intel-gfx] [PATCH 2/5] drm/i915: Pars... Daniel Vetter
- Re: [Intel-gfx] [PATCH 2/5] drm/i915:... Vandana Kannan
- [Intel-gfx] [PATCH 4/5] drm/i915: Idleness detect... Vandana Kannan
- [Intel-gfx] [PATCH 1/5] drm/i915: Adding VBT field... Vandana Kannan
- [Intel-gfx] [PATCH 5/5] drm/i915/bdw: Add support ... Vandana Kannan
- [Intel-gfx] [PATCH 3/5] drm/i915: Add support for ... Vandana Kannan
- [Intel-gfx] [PATCH 0/5] Enabling DRRS in the kernel Vandana Kannan
- [Intel-gfx] [PATCH 3/5] drm/i915: Add support for ... Vandana Kannan
- Re: [Intel-gfx] [PATCH 3/5] drm/i915: Add supp... Jani Nikula
- Re: [Intel-gfx] [PATCH 3/5] drm/i915: Add ... Vandana Kannan
- Re: [Intel-gfx] [PATCH 3/5] drm/i915:... Jani Nikula
- Re: [Intel-gfx] [PATCH 3/5] drm/i... Vandana Kannan