Den 07.11.2022 11.07, skrev Maxime Ripard: > Hi Noralf, > > On Sun, Nov 06, 2022 at 05:59:23PM +0100, Noralf Trønnes wrote: >> >> >> Den 27.10.2022 00.02, skrev Mateusz Kwiatkowski: >>> Hi Maxime, >>> >>> First of all, nice idea with the helper function that can be reused by >>> different >>> drivers. This is neat! >>> >>> But looking at this function, it feels a bit overcomplicated. You're >>> creating >>> the two modes, then checking which one is the default, then set the >>> preferred >>> one and possibly reorder them. Maybe it can be simplified somehow? >>> >>> Although when I tried to refactor it myself, I ended up with something >>> that's >>> not better at all. Maybe it needs to be complicated, after all :( >>> >> >> I also thought that the function was complicated/difficult to read, in >> particular the index stuff at the end, but I also failed in finding a >> "better" solution, just a different one ;) > > I think I like yours better still :) > > Can I bring it into my series, with your authorship and SoB? > Sure, no problem. Noralf.
- [Intel-gfx] [PATCH v6 12/23] drm/connector: Add a func... maxime
- [Intel-gfx] [PATCH v6 14/23] drm/modes: Properly gener... maxime
- Re: [Intel-gfx] [PATCH v6 14/23] drm/modes: Prope... Mateusz Kwiatkowski
- Re: [Intel-gfx] [PATCH v6 14/23] drm/modes: Prope... Noralf Trønnes
- [Intel-gfx] [PATCH v6 18/23] drm/atomic-helper: Add an... maxime
- [Intel-gfx] [PATCH v6 16/23] drm/probe-helper: Provide... maxime
- Re: [Intel-gfx] [PATCH v6 16/23] drm/probe-helper... Mateusz Kwiatkowski
- Re: [Intel-gfx] [PATCH v6 16/23] drm/probe-he... Maxime Ripard
- Re: [Intel-gfx] [PATCH v6 16/23] drm/probe-he... Noralf Trønnes
- Re: [Intel-gfx] [PATCH v6 16/23] drm/prob... Maxime Ripard
- Re: [Intel-gfx] [PATCH v6 16/23] drm/... Noralf Trønnes
- Re: [Intel-gfx] [PATCH v6 16/23] drm/probe-helper... Noralf Trønnes
- Re: [Intel-gfx] [PATCH v6 16/23] drm/probe-he... Maxime Ripard
- Re: [Intel-gfx] [PATCH v6 16/23] drm/prob... Noralf Trønnes
- Re: [Intel-gfx] [PATCH v6 16/23] drm/... Maxime Ripard
- [Intel-gfx] [PATCH v6 19/23] drm/vc4: vec: Use TV Rese... maxime
- [Intel-gfx] [PATCH v6 17/23] drm/atomic-helper: Add a ... maxime
- [Intel-gfx] [PATCH v6 15/23] drm/modes: Introduce more... maxime
- [Intel-gfx] [PATCH v6 23/23] drm/sun4i: tv: Convert to... maxime
- [Intel-gfx] [PATCH v6 20/23] drm/vc4: vec: Check for V... maxime
- [Intel-gfx] [PATCH v6 21/23] drm/vc4: vec: Convert to ... maxime