Ensure i915_pxp_tee_component_bind / unbind implicitly sorts out
getting the correct PXP control-context from the PXP-owning-GT
when establishing or ending connection.

Signed-off-by: Alan Previn <alan.previn.teres.ale...@intel.com>
---
 drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c 
b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c
index 792a56edfde7..05d5ad1092b8 100644
--- a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c
+++ b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c
@@ -20,8 +20,12 @@
 static inline struct intel_pxp *i915_dev_to_pxp(struct device *i915_kdev)
 {
        struct drm_i915_private *i915 = kdev_to_i915(i915_kdev);
+       struct intel_gt *gt = intel_pxp_get_owning_gt(i915);
 
-       return &to_gt(i915)->pxp;
+       if (!gt)
+               return NULL;
+
+       return &gt->pxp;
 }
 
 static int intel_pxp_tee_io_message(struct intel_pxp *pxp,
@@ -128,10 +132,16 @@ static int i915_pxp_tee_component_bind(struct device 
*i915_kdev,
 {
        struct drm_i915_private *i915 = kdev_to_i915(i915_kdev);
        struct intel_pxp *pxp = i915_dev_to_pxp(i915_kdev);
-       struct intel_uc *uc = &pxp_to_gt(pxp)->uc;
+       struct intel_uc *uc;
        intel_wakeref_t wakeref;
        int ret = 0;
 
+       if (!pxp) {
+               drm_warn(&i915->drm, "tee comp binding without a PXP-owner 
GT\n");
+               return -ENODEV;
+       }
+       uc = &pxp_to_gt(pxp)->uc;
+
        mutex_lock(&pxp->tee_mutex);
        pxp->pxp_component = data;
        pxp->pxp_component->tee_dev = tee_kdev;
@@ -167,6 +177,9 @@ static void i915_pxp_tee_component_unbind(struct device 
*i915_kdev,
        struct intel_pxp *pxp = i915_dev_to_pxp(i915_kdev);
        intel_wakeref_t wakeref;
 
+       if (!pxp)
+               return;
+
        if (intel_pxp_is_enabled(i915))
                with_intel_runtime_pm_if_in_use(&i915->runtime_pm, wakeref)
                        intel_pxp_fini_hw(pxp);
-- 
2.34.1

Reply via email to