Re: [Intel-gfx] [PATCH 2/7] drm/i915/uc: fetch uc firmwares for each GT

[John Harrison]

On 9/22/2022 15:11, Daniele Ceraolo Spurio wrote:

The FW binaries are independently loaded on each GT. On MTL, the memory
is shared so we could potentially re-use a single allocation, but on
discrete multi-gt platforms we are going to need independent copies,
so it is easier to do the same on MTL as well, given that the amount
of duplicated memory is relatively small (~500K).

Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com>
Cc: John Harrison <john.c.harri...@intel.com>
Cc: Alan Previn <alan.previn.teres.ale...@intel.com>

Reviewed-by: John Harrison <john.c.harri...@intel.com>

---
  drivers/gpu/drm/i915/i915_gem.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 88df9a35e0fe..a5b192ac885c 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1140,7 +1140,8 @@ int i915_gem_init(struct drm_i915_private *dev_priv)
        if (ret)
                return ret;

- intel_uc_fetch_firmwares(&to_gt(dev_priv)->uc);

+       for_each_gt(gt, dev_priv, i)
+               intel_uc_fetch_firmwares(&gt->uc);
        intel_wopcm_init(&dev_priv->wopcm);

ret = i915_init_ggtt(dev_priv);