Re: [Intel-gfx] [PATCH 01/16] drm/i915/vm_bind: Expose vm lookup function

[Matthew Auld]

On 28/09/2022 07:19, Niranjana Vishwanathapura wrote:

Make i915_gem_vm_lookup() function non-static as it will be
used by the vm_bind feature.

Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathap...@intel.com>
Signed-off-by: Andi Shyti <andi.sh...@linux.intel.com>

Acked-by: Matthew Auld <matthew.a...@intel.com>

---
  drivers/gpu/drm/i915/gem/i915_gem_context.c | 11 ++++++++++-
  drivers/gpu/drm/i915/gem/i915_gem_context.h |  3 +++
  2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c 
b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index 0bcde53c50c6..f4e648ec01ed 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -346,7 +346,16 @@ static int proto_context_register(struct 
drm_i915_file_private *fpriv,
        return ret;
  }

-static struct i915_address_space *

+/**
+ * i915_gem_vm_lookup() - looks up for the VM reference given the vm id
+ * @file_priv: the private data associated with the user's file
+ * @id: the VM id
+ *
+ * Finds the VM reference associated to a specific id.
+ *
+ * Returns the VM pointer on success, NULL in case of failure.
+ */
+struct i915_address_space *
  i915_gem_vm_lookup(struct drm_i915_file_private *file_priv, u32 id)
  {
        struct i915_address_space *vm;
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.h 
b/drivers/gpu/drm/i915/gem/i915_gem_context.h
index e5b0f66ea1fe..899fa8f1e0fe 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.h
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.h
@@ -139,6 +139,9 @@ int i915_gem_context_setparam_ioctl(struct drm_device *dev, 
void *data,
  int i915_gem_context_reset_stats_ioctl(struct drm_device *dev, void *data,
                                       struct drm_file *file);

+struct i915_address_space *

+i915_gem_vm_lookup(struct drm_i915_file_private *file_priv, u32 id);
+
  struct i915_gem_context *
  i915_gem_context_lookup(struct drm_i915_file_private *file_priv, u32 id);