Platforms with FlatCCS do not use auxiliary planes for compression
control data and thus do not need traditional aux table invalidation
(and the registers no longer even exist).

Original-author: CQ Tang
Signed-off-by: Matt Roper <matthew.d.ro...@intel.com>
---
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 28 ++++++++++++++++--------
 1 file changed, 19 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c 
b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c
index 1f8cf4f790b2..13bbbf5d9737 100644
--- a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c
+++ b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c
@@ -231,7 +231,7 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 
        if (mode & EMIT_INVALIDATE) {
                u32 flags = 0;
-               u32 *cs;
+               u32 *cs, count;
 
                flags |= PIPE_CONTROL_COMMAND_CACHE_INVALIDATE;
                flags |= PIPE_CONTROL_TLB_INVALIDATE;
@@ -246,7 +246,12 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 
                flags |= PIPE_CONTROL_CS_STALL;
 
-               cs = intel_ring_begin(rq, 8 + 4);
+               if (!HAS_FLAT_CCS(rq->engine->i915))
+                       count = 8 + 4;
+               else
+                       count = 8;
+
+               cs = intel_ring_begin(rq, count);
                if (IS_ERR(cs))
                        return PTR_ERR(cs);
 
@@ -259,8 +264,10 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 
                cs = gen8_emit_pipe_control(cs, flags, LRC_PPHWSP_SCRATCH_ADDR);
 
-               /* hsdes: 1809175790 */
-               cs = gen12_emit_aux_table_inv(GEN12_GFX_CCS_AUX_NV, cs);
+               if (!HAS_FLAT_CCS(rq->engine->i915)) {
+                       /* hsdes: 1809175790 */
+                       cs = gen12_emit_aux_table_inv(GEN12_GFX_CCS_AUX_NV, cs);
+               }
 
                *cs++ = preparser_disable(false);
                intel_ring_advance(rq, cs);
@@ -275,12 +282,15 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 
mode)
        u32 cmd, *cs;
 
        cmd = 4;
-       if (mode & EMIT_INVALIDATE)
+       if (mode & EMIT_INVALIDATE) {
                cmd += 2;
-       if (mode & EMIT_INVALIDATE)
-               aux_inv = rq->engine->mask & ~BIT(BCS0);
-       if (aux_inv)
-               cmd += 2 * hweight32(aux_inv) + 2;
+
+               if (!HAS_FLAT_CCS(rq->engine->i915)) {
+                       aux_inv = rq->engine->mask & ~BIT(BCS0);
+                       if (aux_inv)
+                               cmd += 2 * hweight32(aux_inv) + 2;
+               }
+       }
 
        cs = intel_ring_begin(rq, cmd);
        if (IS_ERR(cs))
-- 
2.34.1

Reply via email to