Hi Jordan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next 
drm/drm-next tegra-drm/drm/tegra/for-next v5.17-rc5 next-20220225]
[cannot apply to airlied/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Jordan-Justen/GuC-HWCONFIG-with-documentation/20220227-161945
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-a011 
(https://download.01.org/0day-ci/archive/20220227/202202271904.1rr5ckwf-...@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 
d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # 
https://github.com/0day-ci/linux/commit/7a92eba9714ffe68202fee73b9916d35b0da2968
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Jordan-Justen/GuC-HWCONFIG-with-documentation/20220227-161945
        git checkout 7a92eba9714ffe68202fee73b9916d35b0da2968
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 
O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/i915/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:110: warning: Function 
parameter or member 'gt' not described in 'guc_hwconfig_init'
>> drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:110: warning: expecting 
>> prototype for intel_guc_hwconfig_init(). Prototype was for 
>> guc_hwconfig_init() instead
   drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:143: warning: Function 
parameter or member 'gt' not described in 'intel_gt_init_hwconfig'
   drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:156: warning: Function 
parameter or member 'gt' not described in 'intel_gt_fini_hwconfig'


vim +110 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c

   102  
   103  /**
   104   * intel_guc_hwconfig_init - Initialize the HWConfig
   105   *
   106   * Retrieve the HWConfig table from the GuC and save it locally.
   107   * It can then be queried on demand by other users later on.
   108   */
   109  static int guc_hwconfig_init(struct intel_gt *gt)
 > 110  {
   111          struct intel_hwconfig *hwconfig = &gt->info.hwconfig;
   112          struct intel_guc *guc = &gt->uc.guc;
   113          int ret;
   114  
   115          if (!has_table(gt->i915))
   116                  return 0;
   117  
   118          ret = guc_hwconfig_discover_size(guc, hwconfig);
   119          if (ret)
   120                  return ret;
   121  
   122          hwconfig->ptr = kmalloc(hwconfig->size, GFP_KERNEL);
   123          if (!hwconfig->ptr) {
   124                  hwconfig->size = 0;
   125                  return -ENOMEM;
   126          }
   127  
   128          ret = guc_hwconfig_fill_buffer(guc, hwconfig);
   129          if (ret < 0) {
   130                  intel_gt_fini_hwconfig(gt);
   131                  return ret;
   132          }
   133  
   134          return 0;
   135  }
   136  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Reply via email to