On Mon, Jan 31, 2022 at 10:05:38PM +0100, Daniel Vetter wrote: > fb_set_var requires we hold the fb_info lock. Or at least this now > matches what the ioctl does ... > > Note that ps3fb and sh_mobile_lcdcfb are busted in different ways here, > but I will not fix them up. > > Also in practice this isn't a big deal, because really variable fbdev > state is actually protected by console_lock (because fbcon just > doesn't bother with lock_fb_info() at all), and lock_fb_info > protecting anything is really just a neat lie. But that's a much > bigger fish to fry. > > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> > Cc: Helge Deller <del...@gmx.de> > Cc: Daniel Vetter <dan...@ffwll.ch> > Cc: Qing Wang <wangq...@vivo.com> > Cc: Sam Ravnborg <s...@ravnborg.org> Acked-by: Sam Ravnborg <s...@ravnborg.org>
- Re: [Intel-gfx] [PATCH 03/21] fbcon: Restore fbcon... Helge Deller
- Re: [Intel-gfx] [PATCH 03/21] fbcon: Restore f... Helge Deller
- Re: [Intel-gfx] [PATCH 03/21] fbcon: Restore f... Daniel Vetter
- Re: [Intel-gfx] [PATCH 03/21] fbcon: Resto... Helge Deller
- Re: [Intel-gfx] [PATCH 03/21] fbcon: R... Daniel Vetter
- Re: [Intel-gfx] [PATCH 03/21] fbc... Helge Deller
- Re: [Intel-gfx] [PATCH 03/21]... Daniel Vetter
- [Intel-gfx] [PATCH 04/21] fbcon: delete a few unneeded ... Daniel Vetter
- [Intel-gfx] [PATCH 07/21] fbdev/sysfs: Fix locking Daniel Vetter
- Re: [Intel-gfx] [PATCH 07/21] fbdev/sysfs: Fix loc... Sam Ravnborg
- [Intel-gfx] [PATCH 05/21] fbcon: Introduce wrapper for ... Daniel Vetter
- [Intel-gfx] [PATCH 09/21] fbcon: Replace FBCON_FLAGS_IN... Daniel Vetter
- Re: [Intel-gfx] [PATCH 09/21] fbcon: Replace FBCON... Thomas Zimmermann
- Re: [Intel-gfx] [PATCH 09/21] fbcon: Replace F... Geert Uytterhoeven
- Re: [Intel-gfx] [PATCH 09/21] fbcon: Replace FBCON... Sam Ravnborg
- [Intel-gfx] [PATCH 12/21] fbcon: Ditch error handling f... Daniel Vetter
- [Intel-gfx] [PATCH 08/21] fbcon: Use delayed work for c... Daniel Vetter
- [Intel-gfx] [PATCH 10/21] fb: Delete fb_info->queue Daniel Vetter