Hi Daniel, I love your patch! Perhaps something to improve:
[auto build test WARNING on tegra-drm/drm/tegra/for-next] [also build test WARNING on drm/drm-next linus/master v5.17-rc2 next-20220131] [cannot apply to airlied/drm-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/some-fbcon-patches-mostly-locking/20220201-050907 base: git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20220201/202202010613.ht19hztx-...@intel.com/config) compiler: mips-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/7a27c0ce71acfa8b67787d298de9836376fcc323 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Daniel-Vetter/some-fbcon-patches-mostly-locking/20220201-050907 git checkout 7a27c0ce71acfa8b67787d298de9836376fcc323 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash drivers/video/fbdev/core/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All warnings (new ones prefixed by >>): drivers/video/fbdev/core/fbcon.c: In function 'con2fb_acquire_newinfo': >> drivers/video/fbdev/core/fbcon.c:721:27: warning: variable 'ops' set but not >> used [-Wunused-but-set-variable] 721 | struct fbcon_ops *ops = NULL; | ^~~ vim +/ops +721 drivers/video/fbdev/core/fbcon.c ^1da177e4c3f415 drivers/video/console/fbcon.c Linus Torvalds 2005-04-16 717 ^1da177e4c3f415 drivers/video/console/fbcon.c Linus Torvalds 2005-04-16 718 static int con2fb_acquire_newinfo(struct vc_data *vc, struct fb_info *info, 7a27c0ce71acfa8 drivers/video/fbdev/core/fbcon.c Daniel Vetter 2022-01-31 719 int unit) ^1da177e4c3f415 drivers/video/console/fbcon.c Linus Torvalds 2005-04-16 720 { ^1da177e4c3f415 drivers/video/console/fbcon.c Linus Torvalds 2005-04-16 @721 struct fbcon_ops *ops = NULL; ba35a78b17408b6 drivers/video/fbdev/core/fbcon.c Daniel Vetter 2022-01-31 722 int err; ^1da177e4c3f415 drivers/video/console/fbcon.c Linus Torvalds 2005-04-16 723 ba35a78b17408b6 drivers/video/fbdev/core/fbcon.c Daniel Vetter 2022-01-31 724 err = fbcon_open(info); ba35a78b17408b6 drivers/video/fbdev/core/fbcon.c Daniel Vetter 2022-01-31 725 if (err) ba35a78b17408b6 drivers/video/fbdev/core/fbcon.c Daniel Vetter 2022-01-31 726 return err; ^1da177e4c3f415 drivers/video/console/fbcon.c Linus Torvalds 2005-04-16 727 7a27c0ce71acfa8 drivers/video/fbdev/core/fbcon.c Daniel Vetter 2022-01-31 728 ops = info->fbcon_par; d1baa4ffa677bf6 drivers/video/console/fbcon.c Antonino A. Daplas 2007-07-17 729 d1baa4ffa677bf6 drivers/video/console/fbcon.c Antonino A. Daplas 2007-07-17 730 if (vc) b73deed32d08740 drivers/video/console/fbcon.c Antonino A. Daplas 2006-01-09 731 set_blitting_type(vc, info); ^1da177e4c3f415 drivers/video/console/fbcon.c Linus Torvalds 2005-04-16 732 ^1da177e4c3f415 drivers/video/console/fbcon.c Linus Torvalds 2005-04-16 733 return err; ^1da177e4c3f415 drivers/video/console/fbcon.c Linus Torvalds 2005-04-16 734 } ^1da177e4c3f415 drivers/video/console/fbcon.c Linus Torvalds 2005-04-16 735 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
