On Fri, Oct 11, 2013 at 11:21:04AM -0300, Paulo Zanoni wrote: > 2013/10/9 <ville.syrj...@linux.intel.com>:
[snip] > > + previous.enable_fbc_wm = !(I915_READ(DISP_ARB_CTL) & > > DISP_FBC_WM_DIS); > > + > > + if (memcmp(results, &previous, sizeof(*results)) == 0) > > This may cause problems since we're also comparing the structure > paddings. It seems "results" is already zero-initialized, so if you > also zero-initialize "previous" we'll probably be fine with the > memcmp(). But my fear is that future code changes will break this, so > if you stick with the new memcmp please add a comment remembering us > that we rely on zero-initializing stuff. Or maybe keep the > old-big-ugly code. I've added a comment about this and then smashed your presumed r-b onto the patch. Please scream if the patch as merged isn't good enough. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
