On Thu, 07 Oct 2021, Animesh Manna <animesh.ma...@intel.com> wrote: > has_panel_replay flag is used to check panel replay state > which is part of crtc_state structure. > > Signed-off-by: Animesh Manna <animesh.ma...@intel.com> > --- > drivers/gpu/drm/i915/display/intel_display.c | 1 + > drivers/gpu/drm/i915/display/intel_psr.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c > b/drivers/gpu/drm/i915/display/intel_display.c > index 4f0badb11bbb..a30b6fe87dfc 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -8136,6 +8136,7 @@ intel_pipe_config_compare(const struct intel_crtc_state > *current_config, > PIPE_CONF_CHECK_BOOL(has_psr); > PIPE_CONF_CHECK_BOOL(has_psr2); > PIPE_CONF_CHECK_BOOL(enable_psr2_sel_fetch); > + PIPE_CONF_CHECK_BOOL(has_panel_replay); > PIPE_CONF_CHECK_I(dc3co_exitline); > } > } > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c > b/drivers/gpu/drm/i915/display/intel_psr.c > index 197cab7551c6..756f3c775e71 100644 > --- a/drivers/gpu/drm/i915/display/intel_psr.c > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > @@ -1050,6 +1050,8 @@ void intel_psr_get_config(struct intel_encoder *encoder, > */ > pipe_config->has_psr = true; > pipe_config->has_psr2 = intel_dp->psr.psr2_enabled; > + pipe_config->has_panel_replay = intel_dp->psr.enabled && > + intel_dp_is_edp(intel_dp);
Get config is supposed to read the config from hardware, and then the state checker compares sw and hw states. This seems off. BR, Jani. > pipe_config->infoframes.enable |= > intel_hdmi_infoframe_enable(DP_SDP_VSC); > > if (!intel_dp->psr.psr2_enabled) -- Jani Nikula, Intel Open Source Graphics Center
