On Tue, Sep 17, 2013 at 05:02:03PM -0700, Ben Widawsky wrote:
> > The code does
> > 
> >     exec_start = i915_gem_obj_offset(batch_obj, vm) +
> >                     args->batch_start_offset;
> >     exec_len = args->batch_len;
> >     ...
> >     ret = ring->dispatch_execbuffer(ring,
> >                                     exec_start, exec_len,
> >                                     flags);
> >     if (ret)
> >             goto err;
> > 
> > So we lookup the address of the batch buffer in the wrong vm for
> > I915_DISPATCH_SECURE.
> > -Chris
> > 
> 
> But this is very easily solved, no?
> 
> http://cgit.freedesktop.org/~bwidawsk/drm-intel/tree/drivers/gpu/drm/i915/i915_gem_execbuffer.c?h=ppgtt#n1083

No, just because the batch once had a ggtt entry doesn't mean the CS is
going to use the ggtt for this execution...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to