Hi Daniele,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next char-misc/char-misc-testing v5.13-rc3 
next-20210525]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Daniele-Ceraolo-Spurio/drm-i915-Introduce-Intel-PXP/20210525-135106
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # 
https://github.com/0day-ci/linux/commit/b3c322331aa6685d40bb5b4cbf90b1d8ed48c9e0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Daniele-Ceraolo-Spurio/drm-i915-Introduce-Intel-PXP/20210525-135106
        git checkout b3c322331aa6685d40bb5b4cbf90b1d8ed48c9e0
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/i915/pxp/intel_pxp_cmd.c:94:5: error: no previous prototype 
>> for 'intel_pxp_terminate_session' [-Werror=missing-prototypes]
      94 | int intel_pxp_terminate_session(struct intel_pxp *pxp, u32 id)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +/intel_pxp_terminate_session +94 drivers/gpu/drm/i915/pxp/intel_pxp_cmd.c

    93  
  > 94  int intel_pxp_terminate_session(struct intel_pxp *pxp, u32 id)
    95  {
    96          struct i915_request *rq;
    97          struct intel_context *ce = pxp->ce;
    98          u32 *cs;
    99          int err;
   100  
   101          if (!intel_pxp_is_enabled(pxp))
   102                  return 0;
   103  
   104          rq = i915_request_create(ce);
   105          if (IS_ERR(rq))
   106                  return PTR_ERR(rq);
   107  
   108          if (ce->engine->emit_init_breadcrumb) {
   109                  err = ce->engine->emit_init_breadcrumb(rq);
   110                  if (err)
   111                          goto out_rq;
   112          }
   113  
   114          cs = intel_ring_begin(rq, SESSION_TERMINATION_LEN(1) + 
WAIT_LEN);
   115          if (IS_ERR(cs)) {
   116                  err = PTR_ERR(cs);
   117                  goto out_rq;
   118          }
   119  
   120          cs = pxp_emit_session_termination(cs, id);
   121          cs = pxp_emit_wait(cs);
   122  
   123          intel_ring_advance(rq, cs);
   124  
   125  out_rq:
   126          i915_request_get(rq);
   127  
   128          if (unlikely(err))
   129                  i915_request_set_error_once(rq, err);
   130  
   131          pxp_request_commit(rq);
   132  
   133          if (!err && i915_request_wait(rq, 0, HZ / 5) < 0)
   134                  err = -ETIME;
   135  
   136          i915_request_put(rq);
   137  
   138          return err;
   139  }
   140  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to