On Fri, Aug 09, 2013 at 10:12:12PM -0700, Ben Widawsky wrote: > I just noticed in our code we don't really check the assertion, and > given some of the code I am changing in this area, I feel a WARN is very > nice to have. > > Signed-off-by: Ben Widawsky <b...@bwidawsk.net>
This is BUG() class. A WARN by itself here isn't going to prevent calamity, so cleanup and let userspace die gracefully. The alternative is random hw borkage (hopefully triggering an OOPS before it gets too far). -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
