Quoting Ville Syrjala (2020-10-21 14:14:39)
> From: Ville Syrjälä <ville.syrj...@linux.intel.com>
>
> Restore RPS for ILK-M. We lost it when an extra HAS_RPS()
> check appeared in intel_rps_enable().
>
> Unfortunaltey this just makes the performance worse on my
> ILK because intel_ips insists on limiting the GPU freq to
> the minimum. If we don't do the RPS init then intel_ips will
> not limit the frequency for whatever reason. Either it can't
> get at some required information and thus makes wrong decisions,
> or we mess up some weights/etc. and cause it to make the wrong
> decisions when RPS init has been done, or the entire thing is
> just wrong. Would require a bunch of reverse engineering to
> figure out what's going on.
>
> Cc: sta...@vger.kernel.org
> Cc: Chris Wilson <ch...@chris-wilson.co.uk>
> Fixes: 9c878557b1eb ("drm/i915/gt: Use the RPM config register to determine
> clk frequencies")
> Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 27964ac0638a..1fe390727d80 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -389,6 +389,7 @@ static const struct intel_device_info ilk_m_info = {
> GEN5_FEATURES,
> PLATFORM(INTEL_IRONLAKE),
> .is_mobile = 1,
> + .has_rps = true,
Oops.
Too bad we have to fight with ips, but presumably it makes some
workloads better, and more importantly restores our previous behaviour.
Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
