I just checked the CI picture and it looks much better indeed.

Only bad case being the gt_pm, which is also failing on other platforms.

So,

Acked-by: Rodrigo Vivi <rodrigo.v...@intel.com>



On Thu, Oct 15, 2020 at 08:41:32AM +0000, K, SrinivasX wrote:
> Hi Hariom,
> 
> With Sunil's help was able to see EHL achieving rc6 state. 
> Verified from sys entries, under no load to gpu rc6_residency_ms counter is 
> changing.
> Also ran all the Rodrigo mention tests and I see them passing. But with 
> i915_selftest dmesg warnings are still seen.
> 
> Thanks,
> Srinivas
> 
> -----Original Message-----
> From: Pandey, Hariom <hariom.pan...@intel.com> 
> Sent: 09 October 2020 23:39
> To: K, SrinivasX <srinivas...@intel.com>
> Cc: Souza, Jose <jose.so...@intel.com>; ch...@chris-wilson.co.uk; Ausmus, 
> James <james.aus...@intel.com>; Nikula, Jani <jani.nik...@intel.com>; Roper, 
> Matthew D <matthew.d.ro...@intel.com>; intel-gfx@lists.freedesktop.org; 
> dri-de...@lists.freedesktop.org; Surendrakumar Upadhyay, TejaskumarX 
> <tejaskumarx.surendrakumar.upadh...@intel.com>; Vivi, Rodrigo 
> <rodrigo.v...@intel.com>
> Subject: RE: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe 
> protection
> 
> Hi Srinivas,
> 
> Take Sunil's help who has recently validated RC6 on EHL DRM tip and found to 
> be passing. If the WA were sporadically failing and if you confirm that RC6 
> is passing, this patch can be proceeded with. 
> 
> Thanks
> Hariom Pandey
> 
> -----Original Message-----
> From: Vivi, Rodrigo <rodrigo.v...@intel.com> 
> Sent: Friday, October 9, 2020 7:09 PM
> To: K, SrinivasX <srinivas...@intel.com>
> Cc: Souza, Jose <jose.so...@intel.com>; ch...@chris-wilson.co.uk; Ausmus, 
> James <james.aus...@intel.com>; Nikula, Jani <jani.nik...@intel.com>; Pandey, 
> Hariom <hariom.pan...@intel.com>; Roper, Matthew D 
> <matthew.d.ro...@intel.com>; intel-gfx@lists.freedesktop.org; 
> dri-de...@lists.freedesktop.org; Surendrakumar Upadhyay, TejaskumarX 
> <tejaskumarx.surendrakumar.upadh...@intel.com>
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe 
> protection
> 
> 
> 
> > On Oct 9, 2020, at 1:31 AM, K, SrinivasX <srinivas...@intel.com> wrote:
> > 
> > Hi Rodrigo,
> > 
> > How do we get W/A and rc6 changes in, do you have any details?
> 
> I told based on what I was seeing on 
> https://intel-gfx-ci.01.org/tree/drm-tip/drmtip-alt.html?
> focusing on the issues that are exclusively for ehl and not happening on 
> other platforms.
> 
> It looks like workarounds are fine there now. so I'm not sure if it was 
> sporadic thing that day.
> 
> for the rc6 there are a few testcases failing around it:
> https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_675/fi-ehl-1/igt@i915_pm_rc6_reside...@rc6-fence.html
> https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_675/fi-ehl-1/igt@i915_pm_rc6_reside...@rc6-idle.html
> https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_675/fi-ehl-1/igt@i915_selftest@live@gt_pm.html#dmesg-warnings415
> 
> > 
> > Thanks,
> > Srinivas
> > 
> > -----Original Message-----
> > From: Souza, Jose <jose.so...@intel.com>
> > Sent: 06 October 2020 23:33
> > To: Vivi, Rodrigo <rodrigo.v...@intel.com>; ch...@chris-wilson.co.uk
> > Cc: Ausmus, James <james.aus...@intel.com>; Nikula, Jani 
> > <jani.nik...@intel.com>; Pandey, Hariom <hariom.pan...@intel.com>; 
> > Roper, Matthew D <matthew.d.ro...@intel.com>; 
> > intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; K, 
> > SrinivasX <srinivas...@intel.com>; Surendrakumar Upadhyay, TejaskumarX 
> > <tejaskumarx.surendrakumar.upadh...@intel.com>
> > Subject: Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove 
> > require_force_probe protection
> > 
> > On Tue, 2020-10-06 at 10:55 -0700, Vivi, Rodrigo wrote:
> >> 
> >>> On Oct 6, 2020, at 10:48 AM, Chris Wilson <ch...@chris-wilson.co.uk> 
> >>> wrote:
> >>> 
> >>> Quoting Souza, Jose (2020-10-06 18:46:45)
> >>>> +Rodrigo and Jani
> >>>> 
> >>>> On Tue, 2020-10-06 at 14:56 +0000, Kamati Srinivas wrote:
> >>>>> Removing force probe protection from EHL platform. Did not observe 
> >>>>> warnings, errors, flickering or any visual defects while doing 
> >>>>> ordinary tasks like browsing and editing documents in a two 
> >>>>> monitor setup.
> >>>> 
> >>>> One of the requirements was also to have CI BAT all green and 
> >>>> shards as green is possible but EHL don't show up in CI results, we 
> >>>> actually have one single EHL machine in CI but I guess it is not able to 
> >>>> run all tests that shards do:
> >>>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9097/filelist.html
> >>> 
> >>> https://intel-gfx-ci.01.org/tree/drm-tip/drmtip-alt.html
> >> 
> >> we are really close to that point. We just need to fix some w/a and
> >> rc6 issues before applying this change.
> >> 
> >>> -Chris
> >> 
> > 
> > Huum okay we have drm-tip results for EHL but if someone sends a patch that 
> > breaks EHL it will not be caught in pre-merge testing.
> > 
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to