Simple adding of i915_gem_object_lock, we may start to pass ww to
get_pages() in the future, but that won't be the case here;
We override shmem's get_pages() handling by calling
i915_gem_object_get_pages_phys(), no ww is needed.

Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_phys.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_phys.c 
b/drivers/gpu/drm/i915/gem/i915_gem_phys.c
index 3960c1d9d415..153de6538378 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_phys.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_phys.c
@@ -182,7 +182,13 @@ int i915_gem_object_attach_phys(struct drm_i915_gem_object 
*obj, int align)
        if (err)
                return err;
 
-       mutex_lock_nested(&obj->mm.lock, I915_MM_GET_PAGES);
+       err = i915_gem_object_lock_interruptible(obj, NULL);
+       if (err)
+               return err;
+
+       err = mutex_lock_interruptible_nested(&obj->mm.lock, I915_MM_GET_PAGES);
+       if (err)
+               goto err_unlock;
 
        if (unlikely(!i915_gem_object_has_struct_page(obj)))
                goto out;
@@ -213,6 +219,8 @@ int i915_gem_object_attach_phys(struct drm_i915_gem_object 
*obj, int align)
 
 out:
        mutex_unlock(&obj->mm.lock);
+err_unlock:
+       i915_gem_object_unlock(obj);
        return err;
 }
 
-- 
2.28.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to