On Tue, Aug 18, 2020 at 12:58:00PM +0100, Chris Wilson wrote: > Quoting Marcin Ślusarz (2020-08-18 12:36:07) > > From: Marcin Ślusarz <marcin.slus...@intel.com> > > > > For some reason intel_gt_reset attempts to reset the GPU twice. > > On one code path (do_reset) "reset" parameter is obeyed, but is > > not on the other one (__intel_gt_set_wedged). > > It's not that simple, we do want to force __intel_gt_set_wedged() to > cancel whatever is running on the GPU as it is used for more than just > failing resets (e.g. around control boundaries) regardless of what the > user may want. > > I'm loathe to add a parameter just to enable unsafe behaviour, but that > may be the compromise.
we probably need this compromise for these cases Marcin faced... what about moving this to intel_get_gpu_reset()? @bool intel_has_gpu_reset(const struct intel_gt *gt) - if (!gt->i915->params.reset) - return NULL; @ static reset_func intel_get_gpu_reset(const struct intel_gt *gt) + if (!gt->i915->params.reset) + return NULL; > -Chris > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
