On Tue, Jul 16, 2013 at 9:30 PM, Paulo Zanoni <przan...@gmail.com> wrote: > 2013/7/16 Chris Wilson <ch...@chris-wilson.co.uk>: >> The INTEL_INFO() macro extracts the dev_private pointer from the device, >> so passing in the dev_private->dev is a long winded circumlocution. >> >> v2: rebase onto uncore >> >> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > > Reviewed-by: Paulo Zanoni <paulo.r.zan...@intel.com> > > I also wouldn't complain if you submitted a patch changing INTEL_INFO > and friends to take dev_priv as argument.
Like I've said on irc imo the real fix is to get drm core off the midlayer drugs and allow embedding of struct drm_device into device driver private structures. At that point it'll boil down to cosmetics since gcc should do a fine job at optimizing away the constant offset. And cosmetics tend to just disrupt ongoing work by causing rebase hell. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
