[Intel-gfx] [PATCH 1/2] drm/i915/gt: Push context state allocation earlier

[Chris Wilson]

Allow for knowledgeable users to preallocate the context state, and to
separate the allocation step from the pinning step during
intel_context_pin()

Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_context.c | 34 +++++++++++++++++++------
 drivers/gpu/drm/i915/gt/intel_context.h |  2 ++
 2 files changed, 28 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_context.c 
b/drivers/gpu/drm/i915/gt/intel_context.c
index 5ea8305fd633..eefe0996ade1 100644
--- a/drivers/gpu/drm/i915/gt/intel_context.c
+++ b/drivers/gpu/drm/i915/gt/intel_context.c
@@ -43,24 +43,42 @@ intel_context_create(struct intel_engine_cs *engine)
        return ce;
 }
 
+int intel_context_alloc_state(struct intel_context *ce)
+{
+       int err = 0;
+
+       if (mutex_lock_interruptible(&ce->pin_mutex))
+               return -EINTR;
+
+       if (!test_bit(CONTEXT_ALLOC_BIT, &ce->flags)) {
+               err = ce->ops->alloc(ce);
+               if (unlikely(err))
+                       goto unlock;
+
+               set_bit(CONTEXT_ALLOC_BIT, &ce->flags);
+       }
+
+unlock:
+       mutex_unlock(&ce->pin_mutex);
+       return 0;
+}
+
 int __intel_context_do_pin(struct intel_context *ce)
 {
        int err;
 
+       if (unlikely(!test_bit(CONTEXT_ALLOC_BIT, &ce->flags))) {
+               err = intel_context_alloc_state(ce);
+               if (err)
+                       return err;
+       }
+
        if (mutex_lock_interruptible(&ce->pin_mutex))
                return -EINTR;
 
        if (likely(!atomic_read(&ce->pin_count))) {
                intel_wakeref_t wakeref;
 
-               if (unlikely(!test_bit(CONTEXT_ALLOC_BIT, &ce->flags))) {
-                       err = ce->ops->alloc(ce);
-                       if (unlikely(err))
-                               goto err;
-
-                       __set_bit(CONTEXT_ALLOC_BIT, &ce->flags);
-               }
-
                err = 0;
                with_intel_runtime_pm(ce->engine->uncore->rpm, wakeref)
                        err = ce->ops->pin(ce);
diff --git a/drivers/gpu/drm/i915/gt/intel_context.h 
b/drivers/gpu/drm/i915/gt/intel_context.h
index 0f5ae4ff3b10..673f5fb2967a 100644
--- a/drivers/gpu/drm/i915/gt/intel_context.h
+++ b/drivers/gpu/drm/i915/gt/intel_context.h
@@ -31,6 +31,8 @@ void intel_context_fini(struct intel_context *ce);
 struct intel_context *
 intel_context_create(struct intel_engine_cs *engine);
 
+int intel_context_alloc_state(struct intel_context *ce);
+
 void intel_context_free(struct intel_context *ce);
 
 /**
-- 
2.25.0.rc1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx