On Wed, 22 May 2013, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä <ville.syrj...@linux.intel.com> > > WARN_ON(!spin_is_locked()) is not a good idea on a UP system w/o > spinlock debugging. Use WARN_ON_SMP() instead.
My bad, thanks for fixing this. Reviewed-by: Jani Nikula <jani.nik...@intel.com> > > Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_panel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_panel.c > b/drivers/gpu/drm/i915/intel_panel.c > index 56f17b2..80bea1d 100644 > --- a/drivers/gpu/drm/i915/intel_panel.c > +++ b/drivers/gpu/drm/i915/intel_panel.c > @@ -332,7 +332,7 @@ static u32 i915_read_blc_pwm_ctl(struct drm_device *dev) > struct drm_i915_private *dev_priv = dev->dev_private; > u32 val; > > - WARN_ON(!spin_is_locked(&dev_priv->backlight.lock)); > + WARN_ON_SMP(!spin_is_locked(&dev_priv->backlight.lock)); > > /* Restore the CTL value if it lost, e.g. GPU reset */ > > -- > 1.8.1.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
