Hi Chris,
On Wednesday, October 2, 2019 6:00:34 PM CEST Chris Wilson wrote:
> If we have a wedged GPU that we need to recover, but fail, add a taint
> for CI to pickup and schedule a reboot.
As your approach has been chosen by CI, FWIW:
Reviewed-by: Janusz Krzysztofik <janusz.krzyszto...@linux.intel.com>
Thanks,
Janusz
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursu...@linux.intel.com>
> Cc: Petri Latvala <petri.latv...@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_reset.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c
> b/drivers/gpu/drm/i915/gt/intel_reset.c
> index e189897e8797..bc1b51349438 100644
> --- a/drivers/gpu/drm/i915/gt/intel_reset.c
> +++ b/drivers/gpu/drm/i915/gt/intel_reset.c
> @@ -872,8 +872,14 @@ static bool __intel_gt_unset_wedged(struct intel_gt *gt)
> ok = !HAS_EXECLISTS(gt->i915); /* XXX better agnosticism desired */
> if (!INTEL_INFO(gt->i915)->gpu_reset_clobbers_display)
> ok = __intel_gt_reset(gt, ALL_ENGINES) == 0;
> - if (!ok)
> + if (!ok) {
> + /*
> + * Warn CI about the unrecoverable wedged condition.
> + * Time for a reboot.
> + */
> + add_taint_for_CI(TAINT_WARN);
> return false;
> + }
>
> /*
> * Undo nop_submit_request. We prevent all new i915 requests from
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
