Let the user know that we have successfully loaded the firmware from the
filesystem and downloaded it to the uC, with a info-level message. In
the process, we can replace the random pointer print out and
uninteresting debug events.

Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Michal Wajdeczko <michal.wajdec...@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c 
b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
index 8ce7210907c0..f04fa051e333 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
@@ -61,9 +61,6 @@ void intel_uc_fw_fetch(struct drm_i915_private *dev_priv,
                         intel_uc_fw_type_repr(uc_fw->type), uc_fw->path);
 
        uc_fw->fetch_status = INTEL_UC_FIRMWARE_PENDING;
-       DRM_DEBUG_DRIVER("%s fw fetch %s\n",
-                        intel_uc_fw_type_repr(uc_fw->type),
-                        intel_uc_fw_status_repr(uc_fw->fetch_status));
 
        err = request_firmware(&fw, uc_fw->path, &pdev->dev);
        if (err) {
@@ -72,9 +69,6 @@ void intel_uc_fw_fetch(struct drm_i915_private *dev_priv,
                goto fail;
        }
 
-       DRM_DEBUG_DRIVER("%s fw size %zu ptr %p\n",
-                        intel_uc_fw_type_repr(uc_fw->type), fw->size, fw);
-
        /* Check the size of the blob before examining buffer contents */
        if (fw->size < sizeof(struct uc_css_header)) {
                DRM_WARN("%s: Unexpected firmware size (%zu, min %zu)\n",
@@ -173,18 +167,17 @@ void intel_uc_fw_fetch(struct drm_i915_private *dev_priv,
        uc_fw->obj = obj;
        uc_fw->size = fw->size;
        uc_fw->fetch_status = INTEL_UC_FIRMWARE_SUCCESS;
-       DRM_DEBUG_DRIVER("%s fw fetch %s\n",
-                        intel_uc_fw_type_repr(uc_fw->type),
-                        intel_uc_fw_status_repr(uc_fw->fetch_status));
+
+       dev_info(dev_priv->drm.dev,
+                "%s: Loaded firmware '%s', v%u.%u\n",
+                intel_uc_fw_type_repr(uc_fw->type), uc_fw->path,
+                uc_fw->major_ver_found, uc_fw->minor_ver_found);
 
        release_firmware(fw);
        return;
 
 fail:
        uc_fw->fetch_status = INTEL_UC_FIRMWARE_FAIL;
-       DRM_DEBUG_DRIVER("%s fw fetch %s\n",
-                        intel_uc_fw_type_repr(uc_fw->type),
-                        intel_uc_fw_status_repr(uc_fw->fetch_status));
 
        DRM_WARN("%s: Failed to fetch firmware %s (error %d)\n",
                 intel_uc_fw_type_repr(uc_fw->type), uc_fw->path, err);
-- 
2.22.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to