Quoting Michal Wajdeczko (2019-05-24 02:30:29) > Due to the upcoming changes to the GuC ABI interface, we must > disable GuC submission mode until final ABI will be available > on all GuC firmwares. > > To avoid regressions on systems configured to run with no longer > supported configuration "enable_guc=3" or "enable_guc=1" clear > GuC submission bit. > > v2: force switch to non-GuC submission mode > > Signed-off-by: Michal Wajdeczko <michal.wajdec...@intel.com> > Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> > Cc: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Rodrigo Vivi <rodrigo.v...@intel.com> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com> > Cc: John Spotswood <john.a.spotsw...@intel.com> > Cc: Vinay Belgaumkar <vinay.belgaum...@intel.com> > Cc: Tony Ye <tony...@intel.com> > Cc: Anusha Srivatsa <anusha.sriva...@intel.com> > Cc: Jeff Mcgee <jeff.mc...@intel.com> > Cc: Antonio Argenziano <antonio.argenzi...@intel.com> > Cc: Sujaritha Sundaresan <sujaritha.sundare...@intel.com> > Cc: Martin Peres <martin.pe...@linux.intel.com> > Acked-by: Martin Peres <martin.pe...@linux.intel.com>
> diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c > index 1a265fbd95c7..f66105d756df 100644 > --- a/drivers/gpu/drm/i915/intel_uc.c > +++ b/drivers/gpu/drm/i915/intel_uc.c > @@ -298,6 +307,10 @@ int intel_uc_init(struct drm_i915_private *i915) > if (!HAS_GUC(i915)) > return -ENODEV; > > + /* XXX: GuC submission is unavailable for now */ > + if (USES_GUC_SUBMISSION(i915)) > + return -EIO; > + This would be a driver programmer error, wouldn't it? Maybe add GEM_BUG_ON() to the later branch that does the check? Regards, Joonas _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
