== Series Details ==

Series: drm/i915: Engine relative MMIO (rev6)
URL   : https://patchwork.freedesktop.org/series/57117/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
1d0e020ea850 drm/i915: Engine relative MMIO
-:90: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#90: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:130:
+#define __MI_LOAD_REGISTER_IMM(x)      MI_INSTR(0x22, 2*(x)-1)
                                                        ^

-:90: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#90: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:130:
+#define __MI_LOAD_REGISTER_IMM(x)      MI_INSTR(0x22, 2*(x)-1)
                                                            ^

-:92: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#92: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:132:
+#define   MI_LRI_ADD_CS_MMIO_START_GEN11       (1<<19)
                                                  ^

-:379: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#379: FILE: drivers/gpu/drm/i915/gt/intel_ringbuffer.c:1699:
+       *cs++ = i915_get_lri_cmd(rq->engine, GEN7_L3LOG_SIZE/4);
                                                            ^

-:434: CHECK:CAMELCASE: Avoid CamelCase: <regLRI>
#434: FILE: drivers/gpu/drm/i915/gt/selftest_workarounds.c:445:
+               u32 regLRI = i915_get_lri_reg(engine, 
engine->whitelist.list[i].reg);

-:528: ERROR:SPACING: space prohibited after that open parenthesis '('
#528: FILE: drivers/gpu/drm/i915/i915_cmd_parser.c:224:
+       CMD(  __MI_LOAD_REGISTER_IMM(1),        SMI,   !F,  0xFF,   W,

-:529: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#529: FILE: drivers/gpu/drm/i915/i915_cmd_parser.c:225:
+       CMD(  __MI_LOAD_REGISTER_IMM(1),        SMI,   !F,  0xFF,   W,
              .reg = { .offset = 1, .mask = 0x007FFFFC, .step = 2 }    ),

total: 1 errors, 0 warnings, 6 checks, 514 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to