Hi Uma.

> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -256,6 +256,13 @@ struct drm_crtc_state {
>       struct drm_property_blob *gamma_mode_caps;
>  
>       /**
> +      * @gamma_mode:
> +      *
> +      * FIXME
> +      */
> +     struct drm_property_blob *gamma_mode;

HEre the name matches, but please add documentation too.

>  
> +struct drm_color_mode_lut {
> +     /* DRM_MODE_LUT_* */
> +     __u32 flags;
> +     /* number of points on the curve */
> +     __u32 count;
> +     /* Name of Gamma Mode */
> +     char name[DRM_PROP_NAME_LEN];
> +     /* Pointer to Lut elements */
> +     __u64 lut;
> +};
From an alignment point of view the __u64 should come before the char name[].
But the above may be fine depending on DRM_PROP_NAME_LEN

        Sam
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to