== Series Details ==
Series: series starting with [01/33] drm/i915/execlists: Move RPCS setup to
context pin
URL : https://patchwork.freedesktop.org/series/55708/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
6abb3bdb8c37 drm/i915/execlists: Move RPCS setup to context pin
44e01a9b8ba3 drm/i915: Measure the required reserved size for request emission
a8be5f976f88 drm/i915: Remove manual breadcumb counting
b4de6f7897c8 drm/i915: Compute the HWS offsets explicitly
2ba1c33378f9 drm/i915/execlists: Suppress preempting self
-:22: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description
(prefer a maximum 75 chars per line)
#22:
References: a2bf92e8cc16 ("drm/i915/execlists: Avoid kicking priority on the
current context")
-:22: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("<title line>")' - ie: 'commit a2bf92e8cc16
("drm/i915/execlists: Avoid kicking priority on the current context")'
#22:
References: a2bf92e8cc16 ("drm/i915/execlists: Avoid kicking priority on the
current context")
total: 1 errors, 1 warnings, 0 checks, 156 lines checked
d23882a69bf8 drm/i915/execlists: Suppress redundant preemption
f6a7e760a383 drm/i915/selftests: Apply a subtest filter
6a91ea6fd2c7 drm/i915: Make all GPU resets atomic
-:33: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.txt
#33: FILE: drivers/gpu/drm/i915/i915_reset.c:149:
+ udelay(50);
-:39: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.txt
#39: FILE: drivers/gpu/drm/i915/i915_reset.c:154:
+ udelay(50);
total: 0 errors, 0 warnings, 2 checks, 176 lines checked
6955a17b590b drm/i915/guc: Disable global reset
0e46060a69ff drm/i915: Remove GPU reset dependence on struct_mutex
-:1279: WARNING:BOOL_BITFIELD: Avoid using bool as bitfield. Prefer bool
bitfields as unsigned int or u<8|16|32>
#1279: FILE: drivers/gpu/drm/i915/intel_hangcheck.c:35:
+ bool wedged:1;
-:1280: WARNING:BOOL_BITFIELD: Avoid using bool as bitfield. Prefer bool
bitfields as unsigned int or u<8|16|32>
#1280: FILE: drivers/gpu/drm/i915/intel_hangcheck.c:36:
+ bool stalled:1;
total: 0 errors, 2 warnings, 0 checks, 1705 lines checked
4f8bac3aae86 drm/i915/selftests: Trim struct_mutex duration for set-wedged
selftest
54d87f290739 drm/i915: Issue engine resets onto idle engines
ceab76765075 drm/i915: Stop tracking MRU activity on VMA
0f21396816a4 drm/i915: Pull VM lists under the VM mutex.
fdb647847171 drm/i915: Move vma lookup to its own lock
-:161: WARNING:USE_SPINLOCK_T: struct spinlock should be spinlock_t
#161: FILE: drivers/gpu/drm/i915/i915_gem_object.h:94:
+ struct spinlock lock;
total: 0 errors, 1 warnings, 0 checks, 290 lines checked
56860703e5fd drm/i915: Always allocate an object/vma for the HWSP
a2ba7cb66608 drm/i915: Add timeline barrier support
ca873c95645e drm/i915: Move list of timelines under its own lock
5263a04ba167 drm/i915: Introduce concept of per-timeline (context) HWSP
2d8b70963a93 drm/i915: Enlarge vma->pin_count
83d209a5ffec drm/i915: Allocate a status page for each timeline
9b0e47a0b162 drm/i915: Share per-timeline HWSP using a slab suballocator
-:79: CHECK:SPACING: No space is necessary after a cast
#79: FILE: drivers/gpu/drm/i915/i915_timeline.c:43:
+ BUILD_BUG_ON(BITS_PER_TYPE(u64) * CACHELINE_BYTES > PAGE_SIZE);
total: 0 errors, 0 warnings, 1 checks, 415 lines checked
4bd03fef836a drm/i915: Track the context's seqno in its own timeline HWSP
083196e5154c drm/i915: Track active timelines
67501f1cc318 drm/i915: Identify active requests
cf16be448222 drm/i915: Remove the intel_engine_notify tracepoint
e94b3cd6cc75 drm/i915: Replace global breadcrumbs with per-context interrupt
tracking
-:18: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915:
Slaughter the thundering i915_wait_request herd")'
#18:
Before commit 688e6c725816, the solution was simple. Every client waking
-:21: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915:
Slaughter the thundering i915_wait_request herd")'
#21:
688e6c725816 introduced an rbtree so that only the earliest waiter on
-:55: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description
(prefer a maximum 75 chars per line)
#55:
References: 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request
herd")
-:55: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915:
Slaughter the thundering i915_wait_request herd")'
#55:
References: 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request
herd")
-:2179: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct
i915_gem_context *' should also have an identifier name
#2179: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:258:
+ struct i915_request *(*request_alloc)(struct i915_gem_context *,
-:2179: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct
intel_engine_cs *' should also have an identifier name
#2179: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:258:
+ struct i915_request *(*request_alloc)(struct i915_gem_context *,
-:2205: WARNING:LINE_SPACING: Missing a blank line after declarations
#2205: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:284:
+ struct i915_request **requests;
+ I915_RND_STATE(prng);
-:2632: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does
MAINTAINERS need updating?
#2632:
deleted file mode 100644
total: 3 errors, 5 warnings, 0 checks, 2572 lines checked
a265ac2617cc drm/i915: Drop fake breadcrumb irq
174f53eceb3f drm/i915: Implement an "idle" barrier
3b1ab1239de6 drm/i915: Keep timeline HWSP allocated until the system is idle
1ed416939ae4 drm/i915/execlists: Refactor out can_merge_rq()
a8ca508c4233 drm/i915: Use HW semaphores for inter-engine synchronisation on
gen8+
-:306: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#306: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:109:
+#define MI_SEMAPHORE_SAD_GT_SDD (0<<12)
^
-:308: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#308: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:111:
+#define MI_SEMAPHORE_SAD_LT_SDD (2<<12)
^
-:309: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#309: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:112:
+#define MI_SEMAPHORE_SAD_LTE_SDD (3<<12)
^
-:310: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#310: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:113:
+#define MI_SEMAPHORE_SAD_EQ_SDD (4<<12)
^
-:311: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#311: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:114:
+#define MI_SEMAPHORE_SAD_NEQ_SDD (5<<12)
^
total: 0 errors, 0 warnings, 5 checks, 270 lines checked
008bb5355846 drm/i915: Prioritise non-busywait semaphore workloads
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
