Hi Praveen,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v4.19-rc4 next-20180921]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/kedar-j-karanje-intel-com/drm-i915-Get-active-pending-request-for-given-context/20180923-012250
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-x014-201838 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/gpu//drm/i915/i915_debugfs.c: In function 'predictive_load_cb':
>> drivers/gpu//drm/i915/i915_debugfs.c:4762:26: error: unused variable 
>> 'engine' [-Werror=unused-variable]
     struct intel_engine_cs *engine;
                             ^~~~~~
>> drivers/gpu//drm/i915/i915_debugfs.c:4761:23: error: unused variable 'id' 
>> [-Werror=unused-variable]
     enum intel_engine_id id;
                          ^~
   drivers/gpu//drm/i915/i915_debugfs.c: In function 'i915_predictive_load_get':
>> drivers/gpu//drm/i915/i915_debugfs.c:4797:27: error: unused variable 
>> 'dev_priv' [-Werror=unused-variable]
     struct drm_i915_private *dev_priv = data;
                              ^~~~~~~~
   cc1: all warnings being treated as errors

vim +/dev_priv +4797 drivers/gpu//drm/i915/i915_debugfs.c

  4755  
  4756  static enum hrtimer_restart predictive_load_cb(struct hrtimer *hrtimer)
  4757  {
  4758          struct drm_i915_private *dev_priv =
  4759                  container_of(hrtimer, typeof(*dev_priv),
  4760                                  pred_timer);
> 4761          enum intel_engine_id id;
> 4762          struct intel_engine_cs *engine;
  4763          struct i915_gem_context *ctx;
  4764          u64 req_pending;
  4765  
  4766          list_for_each_entry(ctx, &dev_priv->contexts.list, link) {
  4767  
  4768                  if (!ctx->name)
  4769                          continue;
  4770  
  4771                  mutex_lock(&dev_priv->pred_mutex);
  4772                  req_pending = ctx->req_cnt;
  4773                  mutex_unlock(&dev_priv->pred_mutex);
  4774  
  4775                  if (req_pending == PENDING_REQ_0)
  4776                          continue;
  4777  
  4778                  if (req_pending > PENDING_REQ_3)
  4779                          ctx->load_type = LOAD_TYPE_HIGH;
  4780                  else if (req_pending == PENDING_REQ_3)
  4781                          ctx->load_type = LOAD_TYPE_MEDIUM;
  4782                  else if (req_pending < PENDING_REQ_3)
  4783                          ctx->load_type = LOAD_TYPE_LOW;
  4784  
  4785                  i915_set_optimum_config(ctx->load_type, ctx, 
KABYLAKE_GT3);
  4786          }
  4787  
  4788          hrtimer_forward_now(hrtimer,
  4789                          
ns_to_ktime(predictive_load_enable*POLL_PERIOD_MS));
  4790  
  4791          return HRTIMER_RESTART;
  4792  }
  4793  
  4794  static int
  4795  i915_predictive_load_get(void *data, u64 *val)
  4796  {
> 4797          struct drm_i915_private *dev_priv = data;
  4798  
  4799          *val = predictive_load_enable;
  4800          return 0;
  4801  }
  4802  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to