Quoting Chris Wilson (2018-05-31 10:30:13) > Quoting Ville Syrjala (2018-05-29 19:33:15) > > From: Ville Syrjälä <ville.syrj...@linux.intel.com> > > > > When we're trying to reinstate the colorkey we might fail on account of > > the plane still being enable with a configuration that prevent the > > use of colorkey. This happens easily with NV12 since the plane scaler > > required by even unscaled NV12 is not compatible with colorkey. > > > > To work around the problem let's try disabling the plane first, then > > re-enable the colorkey, and finally we will try to re-enable the plane. > > The plane re-enable may fail, in which case we'll head to the GPU > > scaling fallback path. The cost is a flash of the colorkey when the > > plane blink off and then back on. > > > > Help me atomic ioctl, you're my only hope! > > > > Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> > > Though I glazed over at the asm patches, I concur that merely adding > further crud is the easiest way to add colorspace encoding support. The > rest of the patches looked fine, so the series is > > Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk> > > Thanks,
And pushed, double thanks. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
