Quoting Chris Wilson (2018-03-27 11:00:32)
> Quoting Chris Wilson (2018-03-26 12:50:35)
> > When cancelling the requests and clearing out the ports following a
> > successful preemption completion, also clear the active flag. I had
> > assumed that all preemptions would be followed by an immediate dequeue
> > (preserving the active user flag), but under rare circumstances we may
> > be triggering a preemption for the second port only for it to have
> > completed before the preemotion kicks in; leaving execlists->active set
> > even though the system is now idle.
> >
> > We can clear the flag inside the common execlists_cancel_port_requests()
> > as the other users also expect the semantics of active being cleared.
> >
> > Fixes: f6322eddaff7 ("drm/i915/preemption: Allow preemption between
> > submission ports")
> > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> > Cc: Michał Winiarski <michal.winiar...@intel.com>
> > Cc: Michel Thierry <michel.thie...@intel.com>
> > Cc: Mika Kuoppala <mika.kuopp...@linux.intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
>
> From the earlier posting,
> Reviewed-by: Mika Kuoppala <mika.kuopp...@linux.intel.com>
>
> Mika, any chance you want to complete the hat check and review the first
> patch as well? :)
s/hat check/hat trick/
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
