Chris Wilson <ch...@chris-wilson.co.uk> writes:

> If the entire device is powered off, we can safely assume that the
> engine is also asleep (and idle).
>
> Reported-by: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
> Fixes: a091d4ee931b ("drm/i915: Hold a wakeref for probing the ring 
> registers")
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
> Cc: Mika Kuoppala <mika.kuopp...@intel.com>

Reviewed-by: Mika Kuoppala <mika.kuopp...@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_engine_cs.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c 
> b/drivers/gpu/drm/i915/intel_engine_cs.c
> index 0ad9184eba97..3efc589a7f37 100644
> --- a/drivers/gpu/drm/i915/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> @@ -1464,7 +1464,9 @@ static bool ring_is_idle(struct intel_engine_cs *engine)
>       struct drm_i915_private *dev_priv = engine->i915;
>       bool idle = true;
>  
> -     intel_runtime_pm_get(dev_priv);
> +     /* If the whole device is asleep, the engine must be idle */
> +     if (!intel_runtime_pm_get_if_in_use(dev_priv))
> +             return true;
>  
>       /* First check that no commands are left in the ring */
>       if ((I915_READ_HEAD(engine) & HEAD_ADDR) !=
> -- 
> 2.16.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to