On Thu, Oct 05, 2017 at 09:36:31AM +0000, Chris Wilson wrote: > Quoting Michał Winiarski (2017-10-05 10:13:41) > > Now that we're handling request resubmission the same way as regular > > submission (from the tasklet), we can move GuC initialization earlier, > > before restarting the engines. This way, we're no longer being in the > > state of flux during engine restart - we're already in user requested > > submission mode. > > Do you remember why it was the other way around?
IIRC we were resubmitting directly from "intel_uc_init_hw". I guess doing that without calling ->init_hw() first was harmful :) -Michał > > > Cc: Chris Wilson <ch...@chris-wilson.co.uk> > > Cc: Michal Wajdeczko <michal.wajdec...@intel.com> > > Cc: Michel Thierry <michel.thie...@intel.com> > > Cc: Mika Kuoppala <mika.kuopp...@intel.com> > > Cc: Oscar Mateo <oscar.ma...@intel.com> > > Signed-off-by: Michał Winiarski <michal.winiar...@intel.com> > Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk> > -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
