On Fri, 2017-09-15 at 07:34 +0000, Szwichtenberg, Radoslaw wrote: > On Thu, 2017-09-14 at 11:09 -0700, Vinay Belgaumkar wrote: > > Added the missing IGT_TEST_DESCRIPTION and some subtest > > descriptions. > > > > v2: Removed duplication, addressed comments, cc'd test author > > > > v3: Only comment abstract code, change some igt_info to igt_debug. > > Changed description to reflect this is a patch, not an RFC. > > > > Cc: Michał Winiarski <michal.winiar...@intel.com> > > Cc: Eric Anholt <e...@anholt.net> > > Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com> > > Cc: Daniel Vetter <daniel.vet...@intel.com> > > > > Signed-off-by: Vinay Belgaumkar <vinay.belgaum...@intel.com> > > LGTM > Reviewed-by: Radoslaw Szwichtenberg <radoslaw.szwichtenb...@intel.com> > Maybe just one minor with the comment style - it would be good to make it consistent across whole file. Let's start comment with a capital letter and finish it with a dot.
Still - my r-b is yours :) -Radek _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
