On Fri, Jul 28, 2017 at 01:08:06PM +0100, Chris Wilson wrote:
> Execute the same batch on each engine and check that the composite fence
> across all engines completes only after the batch is completed on every
> engine.
> 
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> ---
>  tests/gem_exec_fence.c | 120 
> +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 120 insertions(+)
> 
> diff --git a/tests/gem_exec_fence.c b/tests/gem_exec_fence.c
> index b094f585..c7fa249b 100644
> --- a/tests/gem_exec_fence.c
> +++ b/tests/gem_exec_fence.c
> @@ -199,6 +199,111 @@ static void test_fence_busy(int fd, unsigned ring, 
> unsigned flags)
>       gem_quiescent_gpu(fd);
>  }
>  
> +static void test_fence_busy_all(int fd, unsigned flags)
> +{
> +     const int gen = intel_gen(intel_get_drm_devid(fd));
> +     struct drm_i915_gem_exec_object2 obj;
> +     struct drm_i915_gem_relocation_entry reloc;
> +     struct drm_i915_gem_execbuffer2 execbuf;
> +     struct timespec tv;
> +     uint32_t *batch;
> +     unsigned int engine;
> +     int all, i, timeout;

[SNIP]

> +     for_each_engine(fd, engine) {
> +             int fence, new;
> +
> +             execbuf.flags = engine | LOCAL_EXEC_FENCE_OUT;
> +             execbuf.rsvd2 = -1;
> +             gem_execbuf_wr(fd, &execbuf);
> +             fence = execbuf.rsvd2 >> 32;
> +             igt_assert(fence != -1);
> +
> +             if (all < 0) {
> +                     all = fence;
> +                     break;
> +             }

So... In case we're getting an error from previous sync_file_merge, we'll just
silently continue rather than fail? Or am I missing something here?

> +
> +             new = sync_fence_merge(all, fence);
> +             close(all);
> +             close(fence);
> +
> +             all = new;
> +     }
> +
> +     igt_assert(gem_bo_busy(fd, obj.handle));
> +     igt_assert(fence_busy(all));
> +
> +     timeout = 120;
> +     if ((flags & HANG) == 0) {

We're never passing HANG flag to this test.

-Michał

> +             *batch = MI_BATCH_BUFFER_END;
> +             __sync_synchronize();
> +             timeout = 1;
> +     }
> +     munmap(batch, 4096);
> +
> +     if (flags & WAIT) {
> +             struct pollfd pfd = { .fd = all, .events = POLLIN };
> +             igt_assert(poll(&pfd, 1, timeout*1000) == 1);
> +     } else {
> +             memset(&tv, 0, sizeof(tv));
> +             while (fence_busy(all))
> +                     igt_assert(igt_seconds_elapsed(&tv) < timeout);
> +     }
> +
> +     igt_assert(!gem_bo_busy(fd, obj.handle));
> +     igt_assert_eq(sync_fence_status(all),
> +                   flags & HANG ? -EIO : SYNC_FENCE_OK);
> +
> +     close(all);
> +     gem_close(fd, obj.handle);
> +
> +     gem_quiescent_gpu(fd);
> +}
> +
>  static void test_fence_await(int fd, unsigned ring, unsigned flags)
>  {
>       const int gen = intel_gen(intel_get_drm_devid(fd));
> @@ -744,6 +849,21 @@ igt_main
>               caps = print_welcome(i915);
>       }
>  
> +     igt_subtest_group {
> +             igt_fixture {
> +                     igt_fork_hang_detector(i915);
> +             }
> +
> +             igt_subtest("basic-busy-all")
> +                     test_fence_busy_all(i915, 0);
> +             igt_subtest("basic-wait-all")
> +                     test_fence_busy_all(i915, WAIT);
> +
> +             igt_fixture {
> +                     igt_stop_hang_detector();
> +             }
> +     }
> +
>       for (e = intel_execution_engines; e->name; e++) {
>               igt_subtest_group {
>                       igt_fixture {
> -- 
> 2.13.3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to