On Fri, Jul 28, 2017 at 01:08:08PM +0100, Chris Wilson wrote: > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > --- > tests/gem_eio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/gem_eio.c b/tests/gem_eio.c > index 3c826626..15120842 100644 > --- a/tests/gem_eio.c > +++ b/tests/gem_eio.c > @@ -53,7 +53,7 @@ static bool i915_reset_control(bool enable) > fd = open(path, O_RDWR); > igt_require(fd >= 0); > > - ret = write(fd, &"NY"[enable], 1) == 1; > + ret = write(fd, &"01"[enable], 1) == 1;
That's a fun way of doing "itoa()" :) How about using helpers? We have igt_sysfs_set_parameter. Other thing is the fact that we're leaving the machine in a non-default state (global reset rather than per-engine reset). We should actually restore the old value after the test. I can also see that's "by design" (hang detector), but if we change the behaviour of hang detector in the future, we may forget to modify gem_eio. -Michał > close(fd); > > return ret; > -- > 2.13.3 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
