On Thu, Mar 30, 2017 at 01:02:52PM +0300, Joonas Lahtinen wrote: > On to, 2017-03-30 at 09:53 +0100, Chris Wilson wrote: > > Since commit 1233e2db199d ("drm/i915: Move object backing storage > > manipulation to its own locking"), i915_gem_object_put_pages() and > > specifically the i915_gem_gtt_finish_pages() may be called from outside > > of the struct_mutex and so we can no longer pass I915_WAIT_LOCKED to > > i915_gem_wait_for_idle. > > > > Fixes: 1233e2db199d ("drm/i915: Move object backing storage manipulation to > > its own locking") > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > > Cc: Chris Wilson <ch...@chris-wilson.co.uk> > > Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> > > Cc: Daniel Vetter <daniel.vet...@intel.com> > > Cc: Jani Nikula <jani.nik...@linux.intel.com> > > Cc: intel-gfx@lists.freedesktop.org > > Cc: <sta...@vger.kernel.org> # v4.10+ > > Is there Bugzilla or did you just hit the assert on your own?
Just reviewing callers of i915_gem_wait_for_idle() prior to refactor. Seems like we got the message across about not using Ironlake + VT'd, or that those that do are using enterprise kernels and won't have lockdep enabled when they finally get the kernel update in a few years time. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx